TODO

• Add documentation
• Add tests
• Try and clean up the hack of there being no UpdateGroup in go-gitlab with a fix there, or decide to live with this particular small aspect of technical debt.

I'm working on a patch to add EditGroup to go-gitlab but until I've proposed that I can't speak to the cadence of getting that integrated neatly; in the interim I'm fairly comfortable with the implementation of resourceGitlabGroupUpdate to propose this as-is and then double back to rework once it is part of the go-gitlab api.

Hah. In the time since thinking about this, the go-gitlab project has gained UpdateGroup; so hold on this; I need to bump the vendoring and then rework in terms of the new API; shouldn't be much work

Once again should be good to go.

Hi @richardc

Please can you tell me, does this remove the need to merge #14483 ?

Paul

It doesn't, I imagine that this will be used in conjunction with the addition of namespace_id in #14483, but it's not superceding that change.

Having said that it might make sense, with @hauleth's blessings, to combine that PR into this one as it'll allow for fairly simple acceptance tests to be added for gitlab_group#namepsace_id in terms of gitlab_group.foo.id

Ok, I can merge them both locally and test them :) Thanks for the feedback

This part LGTM!

% make testacc TEST=./builtin/providers/gitlab                                                                                             ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/24 12:58:24 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/gitlab -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccGitlabDeployKey_basic
--- PASS: TestAccGitlabDeployKey_basic (34.11s)
=== RUN   TestAccGitlabGroup_basic
--- PASS: TestAccGitlabGroup_basic (20.91s)
=== RUN   TestAccGitlabProjectHook_basic
--- PASS: TestAccGitlabProjectHook_basic (27.07s)
=== RUN   TestAccGitlabProject_basic
--- PASS: TestAccGitlabProject_basic (30.81s)
=== RUN   TestGitlab_validation
--- PASS: TestGitlab_validation (0.00s)
=== RUN   TestGitlab_visbilityHelpers
--- PASS: TestGitlab_visbilityHelpers (0.00s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/gitlab	112.902s

Will test the other PR as well now

One thing. AFAIK new versions of GitLab allows to namespacing groups as well.

@hauleth that's not reflected in the v3 api that I can see. Do you have api reference I should look at for a future enhancement?

@richardc I see it is named differently here, so maybe you've already support it: https://docs.gitlab.com/ee/api/groups.html#new-group as parent_id.

@hauleth no, that's the v4 api, so it's not currently supported. I'll make an issue later to track things that will need to be revisited once go-gitlab supports the v4 api and put that on there. You can't have it before then

@richardc ok

Meta-ticket for v4 upgrades created as #14823

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.